URGENT - Fix bug introduced in #349 #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: #349 Fix bug for non-chucked responses without a known content-length (see LargeResponse example)
mathieucarbou
requested review from
me-no-dev,
vortigont and
willmmiles
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug introduced in PR #349 that broke non-chunked HTTP responses without a known content-length. The fix adds conditional logic to handle both known and unknown content-length scenarios correctly.
Key Changes:
- Added conditional check to differentiate between responses with known vs. unknown content-length
- Refactored the buffer size calculation to prevent underflow when
_contentLengthis 0 - Added explanatory comments describing the two response scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willmmiles
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #349
Fix bug for non-chucked responses without a known content-length (see LargeResponse example)
These use cases:
curl -v http://192.168.4.1/2 | grep -o '.' | sort | uniq -cand
curl -v http://192.168.4.1/3 | grep -o '.' | sort | uniq -cwere not working anymore.