Fix CAM issues discovered during update to ifx compiler #1486
Closed
cacraigucar wants to merge 4 commits intoESCOMP:cam_developmentfrom
Closed
Fix CAM issues discovered during update to ifx compiler #1486cacraigucar wants to merge 4 commits intoESCOMP:cam_developmentfrom
cacraigucar wants to merge 4 commits intoESCOMP:cam_developmentfrom
Conversation
The MPI_ibsend calls in edyn_mpi were generating MPI tags by concatenating the source and destination PE numbers which overflows the maximum MPI tag size (~65536) - the original tag numbers were around 10M (e.g., 12341235) Since communicators in mp_mag_jslot is scoped to the cols_comm sub-communicator for a single magnetic longitude column (up to nmagtaskj-1), there is no need for globally unique tags. The code has been updated to use sender rank number which is unique within the sub-communicator (tij) which is isrc at the receiver end.
Collaborator
Author
|
Breaking this PR into two pieces (code mods and the externals update). Closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1484