Skip to content

cam6_4_153: Short-lived halogen chemistry#1470

Merged
fvitt merged 15 commits intoESCOMP:cam_developmentfrom
fvitt:short_lived_halogens
Feb 18, 2026
Merged

cam6_4_153: Short-lived halogen chemistry#1470
fvitt merged 15 commits intoESCOMP:cam_developmentfrom
fvitt:short_lived_halogens

Conversation

@fvitt
Copy link
Collaborator

@fvitt fvitt commented Jan 7, 2026

Closes #1469

fvitt added 2 commits January 6, 2026 16:06
@fvitt
mods from slh_chemistry branch
628491f
@fvitt
add MAM4 test mods for SLH compsets
ddc8003 
	new file:   cime_config/testdefs/testmods_dirs/cam/ts_slh_mam4_outfrq9s/shell_commands
	new file:   cime_config/testdefs/testmods_dirs/cam/ts_slh_mam4_outfrq9s/user_nl_cam
	new file:   cime_config/testdefs/testmods_dirs/cam/ts_slh_mam4_outfrq9s/user_nl_clm
	new file:   cime_config/testdefs/testmods_dirs/cam/wa_slh_mam4_outfrq9s/shell_commands
	new file:   cime_config/testdefs/testmods_dirs/cam/wa_slh_mam4_outfrq9s/user_nl_cam
	new file:   cime_config/testdefs/testmods_dirs/cam/wa_slh_mam4_outfrq9s/user_nl_clm
@fvitt fvitt self-assigned this Jan 7, 2026
@fvitt fvitt marked this pull request as draft January 8, 2026 00:09
@fvitt
Copy link
Collaborator Author

fvitt commented Jan 9, 2026

From @RafaPedroFernandez (CC'd @CAlbertoCuevas):

Please note that I have just made a push for 2 F90 routines in my following GIT:
https://github.com/RafaPedroFernandez/CAM/tree/slh_chemistry_n04_cam6_4_097_rpf

Which is also updated local in derecho:
/glade/u/home/rpfernan/cesm_versions_rpf/derecho_cesm/git_fetch/cesm3_cam6dev_francis/slh_chemistry_n04_cam6_4_097_rpf

Routines are
chemistry.F90:
For SLH, we must call iodine_emissions_srf before the loop to outfld( sflxnam(m), cam_in%cflx(:ncol,m), ncol,lchnk ) in order for SFHOI and SFI2 to be properly written in the output file. If we do not so, the SFHOI and SFI2 are zero in the output file but are somehow included in cam_in%cflx array that is passed to other routines

mo_gas_phase_chmdr.F90
For Iodine washout ... we have always used SAD_ICETROP, which is computed based on CLDICE. This CLDICE was before computed as only ice
cldice(:ncol,k) = q(:ncol,k,cldice_ndx)
and now considers also SNOW
cldice(:ncol,k) = q(:ncol,k,cldice_ndx) + q(:ncol,k,snow_ndx)

Including snow in the variable makes the iodine deposition too efficient, and then we created a new array (ONLYICE) just to compute iodine wet-depositions without affecting other model developments.

@fvitt
more changes from Rafa
55f61c9 
	modified:   src/chemistry/mozart/chemistry.F90
	modified:   src/chemistry/mozart/mo_gas_phase_chemdr.F90
@fvitt fvitt marked this pull request as ready for review January 13, 2026 23:11
@fvitt
add r8 real kind specifiers
48d7fbd 
	modified:   src/chemistry/mozart/mo_usrrxt.F90
cacraigucar
cacraigucar requested changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review - @jimmielin will be reviewing the chemistry section of this PR. My review was on the setup side.

I noticed that there are testing use_cases setup, but I do not see any regression tests being added. Is this an oversight?

jimmielin
jimmielin requested changes Feb 3, 2026
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fvitt, I have a few suggested changes but nothing major.

fvitt added 7 commits February 10, 2026 19:13
@fvitt
Rafa's namelist updates
b2ff1de 
	modified:   bld/namelist_files/namelist_defaults_cam.xml
	modified:   bld/namelist_files/use_cases/2000_trop_strat_cam6_slh.xml
	modified:   bld/namelist_files/use_cases/hist_trop_strat_cam6_slh.xml
	modified:   bld/namelist_files/use_cases/hist_trop_strat_nudged_cam6_slh.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_2000_cam6_slh.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_hist_cam6_slh.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_nudged_cam6_slh.xml
@fvitt
code clean up
7209e28 
	modified:   src/chemistry/mozart/clybryiy_fam.F90
	modified:   src/chemistry/mozart/mo_slh_routines.F90
	modified:   src/chemistry/mozart/mo_srf_emissions.F90
	modified:   src/chemistry/mozart/mo_strato_rates.F90
@fvitt
update discriptions of SLH scaling namelist params
b060e32
@fvitt
revert start data; clean up comments in usrxt (accept correction)
0144e21 
	modified:   cime_config/config_compsets.xml
	modified:   src/chemistry/mozart/mo_usrrxt.F90
@fvitt
Changes suggested by Rafa
d5fa1c0 
	modified:   bld/namelist_files/namelist_definition.xml
	modified:   src/chemistry/mozart/clybryiy_fam.F90
	modified:   src/chemistry/mozart/mo_slh_routines.F90
@fvitt
code cleanup
8bca07e 
	modified:   src/chemistry/mozart/gas_wetdep_opts.F90
	modified:   src/chemistry/mozart/mo_chm_diags.F90
	modified:   src/chemistry/mozart/mo_drydep.F90
	modified:   src/chemistry/mozart/mo_gas_phase_chemdr.F90
	modified:   src/chemistry/mozart/mo_neu_wetdep.F90
	modified:   src/chemistry/mozart/mo_sad.F90
	modified:   src/chemistry/mozart/mo_usrrxt.F90
@fvitt
add slh-chem regression tests
f96c0a4
jimmielin
jimmielin approved these changes Feb 17, 2026
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fvitt and @RafaPedroFernandez for resolving my code review comments. I am happy to approve this now.

I have one remaining suggestion, in regards to the commented-out line of code, that perhaps could be documented better with an extra comment, if you would like to keep that line. But I do not need to review the PR again as it will just be a comment update.

Congratulations and thank you for bringing in SLH chemistry for CAM-chem, this is a great accomplishment.

@cacraigucar cacraigucar changed the title Short-lived halogen chemistry cam6_4_153: Short-lived halogen chemistry Feb 17, 2026
@fvitt fvitt merged commit cef52b3 into ESCOMP:cam_development Feb 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmielin jimmielin jimmielin approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

+2 more reviewers

@lkemmons lkemmons lkemmons left review comments

@RafaPedroFernandez RafaPedroFernandez RafaPedroFernandez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fvitt fvitt

Labels

None yet

Projects

CAM Development
Status: Tag

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fvitt @jimmielin @cacraigucar @lkemmons @RafaPedroFernandez