Add Brockmann Consult GmbH as provider and the EFAST UDP

[JanssenBrm]

No description provided.

[algorithm-services-catalogue]

🔍 Catalogue's Preview Site Deployed

Your changes have been deployed to the preview site:

🔗 Preview URL: https://esa-apex.github.io/apex-algorithms-catalogue-web/pr-preview/pr-303/

This preview will be updated automatically when you push new changes to your PR.

[JanssenBrm]

Thank you @Hneuschmidt for the initial update. I already did the following minor fixes, which allows you to check the results through the preview feature:

• To show the record in the catalogue, the record itself needs to be placed in a records folder.
• The keywords of the service need to be aligned with the following list:

  apex_algorithms/schemas/record.json

  Lines 101 to 128 in 322ce28

  	"keywords": {
  	"type": "array",
  	"description": "The topic or topics of the APEx service. This represents a list of EarthData Taxonomy (https://gcmd.earthdata.nasa.gov/KeywordViewer).",
  	"items": {
  	"type": "string",
  	"enum": [
  	"Agriculture",
  	"Land Use/Land Cover Classification",
  	"Vegetation",
  	"Normalized Difference Vegetation Index (NDVI)",
  	"Leaf Area Index (LAI)",
  	"Fraction of Absorbed Photosynthetic Active Radiation (fAPAR)",
  	"Fraction of Vegetation Coverage (fCOVER)",
  	"Energy Production/Use",
  	"Wind Energy Production/Use",
  	"Solar Energy Production/Use",
  	"Natural Hazards",
  	"Wildfires",
  	"Sentinel-1",
  	"Sentinel-2",
  	"Sentinel-3",
  	"Landsat-8",
  	"Digital Elevation/Terrain Model (DEM)",
  	"ECMWF ERA5",
  	"Data Analysis and Visualization",
  	"Statistical Applications"
  	]
  	},

  . This list is based on the predefined EarthData taxonomy. I have updated the keywords accordingly in fc7258a#diff-fb05d03016cdf2ae882094bc5dffd00368c6802f6eb6d78d185b99956c16fabdR18-R21, but feel free to review it.

In general, I would like to suggest the following changes to enhance the integration in the APEx Algorithm Catalogue:

• If possible, it would be great if you could generate a thumbnail/preview that can be included in the card's header. You can refer to this image through the service record links section. Example: https://github.com/ESA-APEx/apex_algorithms/blob/main/algorithm_catalog/vito/biopar/records/biopar.json#L145-L150
• If you open the EFAST preview details page, you will see that the description is very limited. This is because we are reading the description value from the EFAST UDP. It is a best practice to properly set the description in the UDP JSON itself as it is also visualised in external tooling, such as the web editor, jupyter notebooks and the APEx Algorithm Catalogue. You can even use markdown to write chapters. Example: https://github.com/ESA-APEx/apex_algorithms/blob/main/algorithm_catalog/vito/biopar/openeo_udp/biopar.json#L103
• Optionally, if you want to link to the code repo or some online documentation, you can add these to the links section of the record. This will ensure that a corresponding button is shown in the APEx Algorithm Catalogue.

Feel free to reach out if you need any additional support! Happy to help!

[Hneuschmidt]

Dear Bram, I have created a new pull request addressing your comments (#306 ). I was not sure how to add changes on top of yours in this PR, that's why there is a new one.

[JanssenBrm]

Thank you for the changes @Hneuschmidt, much appreciated! Some feedback:

• The description field is now updated, but strangely rendered. I have asked our dev to have a look at it the reason. In any case, it is rendered using markdown, but it should work with the provided text. However, as it is markdown, you could also improve the rendering a bit more, as I noticed you are using links. As they are not defined as markdown links, they will just be formatted as plain text. Making them markdown links allows users to click on them. It is just a minor suggestion.
• Regarding the notebook, feel free to use the application/x-ipynb+json mime-type. I have created an issue to make this more formal (http://github.com/ESA-APEx/apex_algorithms/issues/307). I did experience a couple of issues when executing the notebook myself (using the Jupyterlite link that is used on the catalogue):
  • The notebook did not contain any instructions to install some of the core libraries, it might be useful include an install statement such as %pip install openeo contextily
  • I got an error on the generation of the maps (OSError: image file is truncated) in the beginning of the notebook.
  • I got an error when trying to download the files (might be a version mismatch of the used openeo client)

File :27
ndvi_job.get_results().download_file(ndvi_cube_pathfrom IPython.display import Image, display)
^
SyntaxError: invalid syntax. Perhaps you forgot a comma?

[Hneuschmidt]

Dear @JanssenBrm,

Thank you for the review. The notebook needs a few small updates in general, I'll make sure to integrate your comments in that update and report back when it is done.

[JanssenBrm]

Thanks @Hneuschmidt! In the meantime, I also got the feedback that the current description of the UDP contains an indentation that is causing the text to be displayed as a code block (https://www.jetbrains.com/help/hub/markdown-syntax.html#indented-code-blocks). Could you have a look at reformatting the description field of the UDP?

[Hneuschmidt]

Dear @JanssenBrm , the notebook has been fixed and dependencies included on the process graph repo.
The notebook is quite heavy and relies on dask, so I don't expect it to run correctly on jupyterlite. Furthermore, the issue you encountered with plotting the spatial extend does not reproduce on my local jupyter server, it may also be related to Jupyterlite.

I suggest we add reduced version of the notebook that works with jupyterlite.

The indents in the UDP description are removed and it now renders correctly in the preview.

From my perspective, the remaining tasks are as follows:

1. Create a reduced version of the example notebook to support jupyterlite
2. Correctly attribute DHI

Anything else?

[JanssenBrm]

Thank you for the attributions @Hneuschmidt. Indeed, we can summarize it using the following todo:

• Create a reduced version of the example notebook to support jupyterlite
• Link the new example notebook to the record and remove the current notebook relationship.
• Correctly attribute DHI
• Add a thumbnail image

BTW - the attribution for DHI is pretty straight forward as you will just need to move the file to the DHI folder.