Skip to content

Lines in options files with only spaces are now ignored, and text of first line with error is printed#3057

Merged
jajhall merged 2 commits into
latestfrom
fix-3049
Jun 11, 2026
Merged

Lines in options files with only spaces are now ignored, and text of first line with error is printed#3057
jajhall merged 2 commits into
latestfrom
fix-3049

Conversation

@jajhall

@jajhall jajhall commented Jun 10, 2026

Copy link
Copy Markdown
Member

I found it irritating that an options file with a line containing only spaces caused an error

Such lines are now skipped, and if an error occurs (elsewhere) the text of the line is now logged, as well as the line number

@jajhall jajhall self-assigned this Jun 10, 2026
@jajhall jajhall requested a review from galabovaa June 10, 2026 14:52
@jajhall

jajhall commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Changes to pdhg.cpp are due to me running clang-format on it. No reason why clang-format CI shouldn't include HiPDLP

@jajhall

jajhall commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

This closes #3049

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.94%. Comparing base (355e646) to head (7ac997f).
⚠️ Report is 1 commits behind head on latest.

Files with missing lines Patch % Lines
highs/pdlp/hipdlp/pdhg.cc 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3057   +/-   ##
=======================================
  Coverage   72.93%   72.94%           
=======================================
  Files         426      426           
  Lines      102183   102198   +15     
  Branches    16444    16443    -1     
=======================================
+ Hits        74529    74547   +18     
+ Misses      27378    27375    -3     
  Partials      276      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa galabovaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jajhall jajhall merged commit f34e900 into latest Jun 11, 2026
485 of 498 checks passed
@jajhall jajhall deleted the fix-3049 branch June 11, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants