Fix: Honor CompareOptions and Culture in RangeSortOptions#2345
Open
lievendf wants to merge 1 commit intoEPPlusSoftware:develop8from
Open
Fix: Honor CompareOptions and Culture in RangeSortOptions#2345lievendf wants to merge 1 commit intoEPPlusSoftware:develop8from
lievendf wants to merge 1 commit intoEPPlusSoftware:develop8from
Conversation
Fixed a bug where the internal string comparer in EPPlus sorting hard-coded StringComparison.CurrentCulture, effectively ignoring the CompareOptions (like Ordinal or IgnoreCase) provided by the user. - Updated EPPlusSortComparerBase to use Culture and CompOptions properties. - Added unit tests to verify linguistic and ordinal case-sensitivity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where range sorting in EPPlus 8 failed to respect the
CompareOptionsset inRangeSortOptions. The internal comparison logic was hard-coded to useStringComparison.CurrentCulture, which prevented users from performing true case-sensitive (Ordinal/Binary) sorts or using specific linguistic rules.Changes
OfficeOpenXml.Sorting.Internal.EPPlusSortComparerBaseto use theCultureandCompOptionsproperties during string comparisons instead of a hard-coded value.CultureInfo.CurrentCultureonly if no specific culture is provided.Verification
Added a new test class
EPPlusTest.Sorting.SortCaseSensitivityTestswith the following test cases:ShouldRespectCaseSensitivity: Verifies that linguistic case-sensitive sorting (a < A) works as expected.ShouldRespectOrdinalCaseSensitivity: Verifies that binary/ordinal sorting (A < a) correctly positions uppercase letters first.All tests passed for both .NET 8.0 and .NET 4.8.1 targets.