Bug/s1019 Inserting rows or Columns when named range is on MAX row or column resulted in nullref#2310
Open
OssianEPPlus wants to merge 2 commits intodevelop8from
Open
Bug/s1019 Inserting rows or Columns when named range is on MAX row or column resulted in nullref#2310OssianEPPlus wants to merge 2 commits intodevelop8from
OssianEPPlus wants to merge 2 commits intodevelop8from
Conversation
OssianEPPlus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inserting rows or columns and having a namedRange on the maxRow or maxColumn Epplus crashed with a nullref exception.
This fix makes Epplus consistent with Excel for these cases. Specifically the behaviour is now:
Absolute References that are a singular cell on the maxRow/maxColumn become "#REF!" errors
Relative References are unaffected
Absolute ranges with a from row NOT on the max row/column but the toRow/toCol adress is now move the Absolute Reference of the fromRow by one as Excel does. for example:
We have a named range Sheet1!$XFB$3:$XFD$3
Insert column is performed on column XEU
the named range changes to Sheet1!$XFC$3:$XFD$3
Epplus is now consistent with Excel on this.