Conversation
Create an explicit instance of ASEDliteConfig to make optional attributes available. This is needed, since `self.function_config.configuration` is an AttrDict and not an ASEDliteConfig.
francescalb
requested changes
Nov 27, 2022
Collaborator
francescalb
left a comment
francescalb
left a comment
There was a problem hiding this comment.
I do not see that the tests that new features are implemented.
It looks fine, but if this is done because a new feature is needed I think it should be refleceted in a (new) test.
francescalb
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Create an explicit instance of ASEDliteConfig to make optional attributes available. This is needed, since
self.function_config.configurationis an AttrDict and not an ASEDliteConfig.