Enhance LLVM hook to cover changes in easyblocks #3881 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LLVM 20.1.7 failed in EESSI/software-layer#1257 (comment), so let's verify that it works now. bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
Contributor
|
The job has been running for almost a day, Slurm has restarted it 5 times for some reason. I suspect that it may run out of memory? I've cancelled the job, otherwise it probably just keeps running. |
Contributor
|
Let's try again with fewer cores (and hence less memory): bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
Contributor
|
The original issue has been solved (failure in the build step), but the build now fails in the test step: The build log has lots of the following errors: |
Contributor
Author
|
Looking into it. |
Contributor
Author
|
So this is apparently due to This was not previously an Issue (for Possible solutions (@boegel @Thyre ideas?):
PS: I guess we have been adding |
Contributor
Author
Results by re-running the test suite manuallyTests ran normally in EB (190 failures with 18 ignored)
Tests ran manually with the the `env.sh` from the EB test command + removing the filtering of LIBRARY_PATH (23 failures with 18 that will be ignored
For the manual one the failed tests seems to mostly be the stuff we usually ignore Ignored tests from the EB report
|
bedroge
approved these changes
Dec 4, 2025
Contributor
bedroge
left a comment
bedroge
left a comment
There was a problem hiding this comment.
Lgtm, it fixes the original issue. The new issue will/can be solved in a separate PR.
Contributor
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
Contributor
|
Staging PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the hook work again after
$EBROOTXXXis not what is being checked anymore directly in the Easyblock afterThis should always work as we are enforcing not doing any configure specific action in the
__init__to not break things with bundles and we are still checking$EBROOTXXXto get the actual paths to the libraries (just not to see if they are a dependency)https://github.com/easybuilders/easybuild-easyblocks/blob/2a7aad714fef75e88297498dbb7cf040c8202667/easybuild/easyblocks/l/llvm.py#L531-L533