Skip to content

Conversation

@jonas-lq
Copy link
Collaborator

Fix for issue #121

A comment gets added to the PR when the user sets one of the following labels without permission:
-bot:build
-bot:deploy

trz42
trz42 previously requested changes Apr 6, 2023
Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Tested it (see trz42/software-layer#62). It works.

It only remains to sync the PR with the main branch in EESSI/eessi-bot-software-layer. Then it can be merged.

Nice work!

boegel
boegel previously requested changes Apr 11, 2023
@jonas-lq jonas-lq marked this pull request as ready for review April 11, 2023 12:08
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge bedroge dismissed stale reviews from boegel and trz42 May 9, 2023 07:53

Comments are addressed, issue has been opened for the refactoring

@bedroge bedroge merged commit ceca354 into EESSI:main May 9, 2023
@jonas-lq jonas-lq deleted the issue#121 branch May 11, 2023 11:07
@boegel boegel added this to the 0.1.0 - initial release milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants