Potential fix for code scanning alert no. 59: Unsafe jQuery plugin #1666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/security/code-scanning/59
To fix the problem, we should ensure that the
altFieldoption can never be interpreted as a HTML string by jQuery. The safest way is to ensure that only a valid selector string is processed, and to avoid passing user-controlled strings that could be parsed as HTML. Specifically, before using$( altField ), we should verify thataltFieldis a string that does NOT start with<, and if it does, we should not use it, or alternatively, escape it or ignore it. Additionally, we should document in comments thataltFieldshould not accept arbitrary user input and must be a selector, not HTML.The best minimal fix within the file is:
_updateAlternatemethod (lines around 8846-8856), before using$( altField ), check thataltFieldis a string and does not start with<.<, skip updating the alternate field or throw an error.This fix should be implemented in the region of
_updateAlternatein sourcefiles/modern/plugins/jquery/jquery-ui-1.12.1.js.Suggested fixes powered by Copilot Autofix. Review carefully before merging.