Potential fix for code scanning alert no. 21: Unsafe expansion of self-closing HTML tag #1665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/security/code-scanning/21
To fix the unsafe expansion of self-closing HTML tags, we should avoid using a regex-based approach to modify HTML structure, especially on potentially untrusted input. Instead, we should parse the HTML using a trusted DOM parser and reconstruct it, or use a well-tested sanitization library to handle such transformations. Since we are restricted to edits within the provided code, the safest approach is to modify
htmlPrefilterto avoid using the regex to expand self-closing tags. The best solution is to leave the input HTML unchanged, or, if possible, use a DOM approach to parse and serialize HTML fragments safely. However, since we cannot introduce a new complex parser and can only add well-known imports, we should makehtmlPrefiltera no-op (return the input unchanged) or, if possible, use a well-known library such as DOMPurify to safely parse and serialize the HTML.Steps:
sourcefiles/modern/plugins/jquery/jquery-2.2.4.js, replace the body ofhtmlPrefilterso that it simply returnshtml(no-op).Suggested fixes powered by Copilot Autofix. Review carefully before merging.