fix: Prevent multi-line titles and descriptions across commands#128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
mainbranch of tmpo.Description
This pull request introduces a new utility function for input sanitization and consistently applies it across several commands to ensure user inputs are single-line, trimmed, and free of line breaks. The update improves input handling and prevents multi-line or malformed strings from being inadvertently processed. Comprehensive unit tests are also added to verify the correctness of the new sanitization logic.
Input sanitization improvements:
SanitizeSingleLineininternal/ui/ui.gothat replaces all newline and carriage return characters in a string with spaces and trims leading/trailing whitespace.strings.TrimSpacecalls withui.SanitizeSingleLinefor user inputs incmd/entries/edit.go,cmd/entries/manual.go,cmd/milestones/start.go, andcmd/tracking/start.goto ensure consistent single-line input handling. [1] [2] [3] [4] [5]Testing enhancements:
SanitizeSingleLineininternal/ui/ui_test.goto cover various edge cases, including different types of whitespace and line breaks.Dependency updates:
stringspackage ininternal/ui/ui.goto support the new sanitization function.