refactor: tmpo backup list now displays backups in chronological order#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
mainbranch of tmpo.Description
This pull request updates the backup listing functionality to sort and display backups in oldest-to-newest order (instead of newest-to-oldest), and updates the CLI output to clearly indicate the latest backup. The test suite and documentation are also updated to match this new behavior.
Backup ordering and display changes:
ListBackupsfunction ininternal/storage/backup.goto return backups sorted oldest-first (1 = oldest), instead of newest-first. This includes updating the sorting logic and the function's documentation comment. [1] [2]cmd/backups/list.goto add a "← latest" tag next to the most recent (latest) backup, making it clear to users which backup is the newest.Test and documentation updates:
TestListBackups_SortedNewestFirsttoTestListBackups_SortedOldestFirstininternal/storage/backup_test.go, and adjusted assertions to expect oldest-first order. [1] [2]