This repository was archived by the owner on May 23, 2024. It is now read-only.
avoid logging error when error callback supplied #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the following issue: While trying to sync the app with an error callback, we should assume that the callback should handle and log the error. In my case, I receive an error that is logged to Sentry whenever an update is not available. Passing an error callback doesn't solve it. Even wrapping it inside try-catch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the following issue:
While trying to sync the app with an error callback, we should assume that the callback should handle and log the error.
In my case, I receive an error that is logged to Sentry whenever an update is not available. Passing an error callback doesn't solve it. Even wrapping it inside try-catch.