Refactor project for JOSS-ready packaging with CI, docs, and ReadMe#51
Merged
Refactor project for JOSS-ready packaging with CI, docs, and ReadMe#51
Conversation
And GitHub Actions workflow for automated pytest testing
… and remove old requirements files.
jdrugo
approved these changes
May 9, 2025
Collaborator
There was a problem hiding this comment.
Changes look mostly good.
One issue is with the pyproject.toml license line, which should just specify the license through license = "BSD-3-Clause" rather than as file and text. This should fix the the failing tests.
Once the test run, the PR can be merged.
…required to convert notebook markdown cells into reStructuredText or HTML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the BlockInverseGPFA package to prepare it for community use, continuous integration, and publication. It includes major packaging, and documentation updates:
[test]: for pytest-based testing[docs]: for Sphinx documentation buildrequirements.txt(no longer needed).