fix: Improve release tag extraction to avoid issues with some curl version#132
Open
theoDep wants to merge 1 commit intoDokploy:mainfrom
Open
fix: Improve release tag extraction to avoid issues with some curl version#132theoDep wants to merge 1 commit intoDokploy:mainfrom
theoDep wants to merge 1 commit intoDokploy:mainfrom
Conversation
5e00a11 to
f903630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix linked to the following issue: #126
Greptile Overview
Greptile Summary
Improved the release tag extraction logic in the installation script to be more robust across different
curlversions. The change splits the version detection into two steps: first storing the effective URL from the GitHub redirect, then validating and extracting the tag only if/tag/is present in the URL. Additionally adds validation to detect if the extraction failed by checking if the version string still containshttp.Confidence Score: 5/5
(2/5) Greptile learns from your feedback when you react with thumbs up/down!