fix: actions in slack notification#4054
Merged
Siumauricio merged 3 commits intoDokploy:canaryfrom Apr 5, 2026
Merged
Conversation
Comment on lines
+240
to
+244
| { | ||
| title: "Details", | ||
| value: `<${buildLink}|View Build Details>`, | ||
| short: false, | ||
| }, |
Contributor
There was a problem hiding this comment.
mrkdwn link won't render in field values without
mrkdwn_in
Slack does not apply mrkdwn formatting to attachment fields.value by default. The <url|text> syntax in value will render as a literal string (e.g. <https://…|View Build Details>) rather than a clickable hyperlink, which is just as broken as the previous approach.
To enable mrkdwn rendering in field values, mrkdwn_in: ["fields"] must be added to the attachment object.
The same issue exists in packages/server/src/utils/notifications/build-success.ts at line 256–260.
Suggested change
| { | |
| title: "Details", | |
| value: `<${buildLink}|View Build Details>`, | |
| short: false, | |
| }, | |
| { | |
| title: "Details", | |
| value: `<${buildLink}|View Build Details>`, | |
| short: false, | |
| }, | |
| ], | |
| mrkdwn_in: ["fields"], |
Contributor
Author
There was a problem hiding this comment.
That doesn't look necessary.
Contributor
Author
|
Do you have some news ? I really need this merge 🙏🏼 Thank you @Siumauricio |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR fixes broken Slack notification actions in the build error and build success notification flows. The original code used a legacy attachment
actionsarray with aurl-based button (type: "button",url: buildLink), which doesn't function without Slack Interactive Components configured on the app. The fix removes theactionsblock and instead adds a "Details" field using Slack's mrkdwn hyperlink syntax (<url|text>).<url|text>syntax in an attachmentfields.valuerequiresmrkdwn_in: ["fields"]on the attachment object to be rendered as an actual hyperlink — without it, Slack renders the text literally (e.g.<https://…|View Build Details>), so the link will still not be clickable.Confidence Score: 3/5
mrkdwn_in: ["fields"], so the build link will still not be clickable for Slack users.actionswith a static link), but the replacement will silently produce unformatted literal text in Slack field values. Addingmrkdwn_in: ["fields"]to both attachments is a one-line fix needed before this works as intended.packages/server/src/utils/notifications/build-error.tsandpackages/server/src/utils/notifications/build-success.tsneedmrkdwn_in: ["fields"]added to their Slack attachment objects.Reviews (1): Last reviewed commit: "fix: actions in slack notification" | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!