feat(backup): additional options for database backups#3445
feat(backup): additional options for database backups#3445paulwer wants to merge 13 commits intoDokploy:canaryfrom
Conversation
…-backup-additional-options
|
Yes. I second that. This is key to restore a db with acl or RLS. Totally necessary for logto for example |
|
@Siumauricio I am very sorry, but I am not able to do testing right now and for the next few weeks. |
…-backup-additional-options
…-backup-additional-options
Additional Comments (1)
The The original To fix, either move the delay before |
|
@greptile-apps please review again (if thats possible 🙈) @Siumauricio I applied all changes suggested by the AI, so i think its ready for review again :) I've added normalization also for all existing command. please check if that suites your code style and if you want to implement it like this. |
What is this PR about?
Adds a new optional field additionalOptions that allows users to pass extra arguments to the dump commands for databases.
We also have created a fix for successfully running dokploy:setup on windows systems
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #3191
Screenshots (if applicable)
Notes
@Siumauricio I tested the ui/api changes for creating / restoring backups, which works fine, but I was not able to test backup jobs for all databases. please validate while reviewing this PR please :)
Please also write suggestion/feedback for UI-Component created by me for ArrayLists, if it matches your style-guide or do necessary changes yourself :)
We also have created a fix for successfully running dokploy:setup on windows systems.
Greptile Summary
Adds
additionalOptionsfield to database backup/restore operations, allowing users to pass custom arguments to dump/restore commands. The implementation includes proper input sanitization vianormalizeBackUpInput/normalizeRestoreInputfunctions that strip unsafe characters. Also includes a Windows compatibility fix for the setup script and a newInputArrayUI component for managing string arrays.additionalOptionsfield to backup schema with JSONB array storageadditionalOptionsinto all backup commands (postgres, mysql, mariadb, mongo)InputArrayReact component for array input managementConfidence Score: 3/5
sh -ccontexts, making them vulnerable to shell injection. The setup.ts change adds an unexplained 5-second delay. The UI components and schema changes look good.packages/server/src/utils/restore/utils.ts(shell injection vulnerabilities) andapps/dokploy/setup.ts(unexplained delay)Last reviewed commit: 52576aa