feat(thread): add reversible inbox-state commands by gnapse · Pull Request #69 · Doist/twist-cli

gnapse · 2026-03-03T22:27:29Z

Summary

This PR makes thread inbox state reversible and scriptable from the CLI.

It adds explicit commands to reopen threads and toggle read state, and moves tw thread done onto the same mutation flow so accidental inbox actions can be undone safely.

What Changed

add tw thread reopen [thread-refs...]
add tw thread mark-read [thread-refs...]
add tw thread mark-unread [thread-refs...]
add tw thread restore [thread-refs...] --unread
move tw thread done onto the same shared batch/state mutation path

Behavior

supports one or many refs, plus --from-file
supports --dry-run
supports --json with per-item before / after snapshots:
- id
- title
- isArchived
- inInbox
- isUnread
- closed
- lastUpdated
idempotent for already-open, already-read, and already-unread cases
bulk mutations require --yes unless --dry-run
mixed-result batches return per-item results and only set a non-zero exit when there are actual item failures

Docs And Tests

update thread help text and examples
update README.md
update skill content and generated skills/twist-cli/SKILL.md
add tests for single-item flows, bulk flows, dry-run, idempotency, restore --unread, and mixed success/failure

Verification

npx vitest run src/__tests__/thread.test.ts

Notes

Repo-wide npm test / npm run build are currently blocked by unrelated pre-existing issues in:

src/commands/away/set.ts
src/commands/thread/reply.ts
src/lib/secure-store.ts

scottlovegrove · 2026-03-21T17:19:20Z

@doistbot /review

gnapse · 2026-04-06T14:28:02Z

@doistbot /review

doistbot

This PR introduces valuable commands for managing thread inbox states and read toggles, bringing them into a unified mutation flow with dry-run and JSON support. These additions significantly improve CLI scriptability and provide a safer path for reversing accidental inbox actions. A few minor adjustments have been noted around simplifying redundant variadic argument checks, ensuring JSON bulk mutations without confirmation correctly trigger an error rather than returning a successful preview, and adjusting the sequence of no-op checks so dry-runs accurately reflect unchanged items.

_{Share Feedback • Review Logs}

doistbot · 2026-04-06T14:35:35Z

src/commands/thread/index.ts

        )
-        .action(markThreadDone)
+        .action((refs, options) => {
+            if ((!refs || refs.length === 0) && !options.fromFile) {


[P3] Commander variadic arguments ([thread-refs...]) are always passed as an array, defaulting to [] if none are provided. The falsy checks and nullish coalescing are redundant here and in the other new commands.

You can simplify this condition to if (refs.length === 0 && !options.fromFile) and call the action directly with refs instead of refs ?? [].

doistbot · 2026-04-06T14:35:35Z

src/commands/thread/state-helpers.ts

+        )
+    }
+
+    const needsConfirmation = rawRefs.length > 1 && !options.yes && !options.dryRun


[P1] In --json mode this turns a bulk mutation without --yes into a successful preview payload with exit code 0, even though nothing was changed. That is easy for automation to misread as success, and it diverges from thread delete, which throws MISSING_YES_FLAG in JSON mode. Consider treating options.json && needsConfirmation as an error (or at least a non-zero exit) instead of a successful preview.

doistbot · 2026-04-06T14:35:35Z

src/commands/thread/state-helpers.ts

+        }
+    }
+
+    if (options.dryRun) {


[P2] The no-op check happens after the confirmation/dry-run branches, so already-open/read/unread threads get reported as preview (Would ... / Dry run: would ...) instead of unchanged. That makes the preview output inaccurate and changes the JSON status for idempotent inputs. Moving the mutationPlan.length === 0 branch above these preview returns would keep no-op items idempotent in dry-run and bulk-preview mode too.

scottlovegrove · 2026-04-07T17:44:21Z

src/commands/thread/state-helpers.ts

+import { assertChannelIsPublic } from '../../lib/public-channels.js'
+import { resolveThreadId } from '../../lib/refs.js'
+
+export type ThreadStateAction = 'done' | 'read' | 'reopen' | 'restore' | 'unread'


Do we not have something for reversing marking a thread as "done"?

scottlovegrove · 2026-04-07T17:47:48Z

src/lib/skills/content.ts


 \`--notify\` automatically resolves IDs: group IDs are routed to the \`groups\` API field, user IDs to \`recipients\`. No special syntax needed.

+Migration note: \`tw thread done\` is reversible via \`tw thread reopen\`.


Is that right? I thought reopen was just for threads that had been explicitly closed? Calling reopen on a non-closed thread will move it to done?

I forgot about closing threads. I'll rethink this a bit then.

# Conflicts: # README.md # src/commands/thread/index.ts

doistbot requested a review from craigcarlyle March 3, 2026 22:27

gnapse force-pushed the ernesto/inbox-state-undo branch 2 times, most recently from 0c70fc3 to 02b29b4 Compare March 3, 2026 22:50

gnapse self-assigned this Mar 3, 2026

craigcarlyle removed their request for review March 5, 2026 03:55

scottlovegrove force-pushed the ernesto/inbox-state-undo branch from 02b29b4 to ebe9108 Compare March 21, 2026 17:15

This comment was marked as outdated.

Sign in to view

gnapse force-pushed the ernesto/inbox-state-undo branch from ebe9108 to 10eeaa4 Compare April 6, 2026 14:21

gnapse changed the title ~~feat: reversible thread inbox state operations~~ Add reversible thread inbox-state commands Apr 6, 2026

gnapse changed the title ~~Add reversible thread inbox-state commands~~ feat(thread): add reversible inbox-state commands Apr 6, 2026

gnapse force-pushed the ernesto/inbox-state-undo branch from 10eeaa4 to 534abc4 Compare April 6, 2026 14:27

gnapse added the 🙋 Ask PR PR must be reviewed before merging label Apr 6, 2026

doistbot reviewed Apr 6, 2026

View reviewed changes

gnapse force-pushed the ernesto/inbox-state-undo branch 2 times, most recently from 8722e53 to 9bc402a Compare April 6, 2026 14:49

gnapse requested a review from scottlovegrove April 7, 2026 17:28

feat(thread): add reversible inbox-state commands

82e9b4a

gnapse force-pushed the ernesto/inbox-state-undo branch from 9bc402a to 82e9b4a Compare April 7, 2026 17:44

scottlovegrove reviewed Apr 7, 2026

View reviewed changes

gnapse added 2 commits April 8, 2026 13:16

Merge remote-tracking branch 'origin/main' into ernesto/inbox-state-undo

310135c

# Conflicts: # README.md # src/commands/thread/index.ts

chore: format thread command imports

a5a05a5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(thread): add reversible inbox-state commands#69

feat(thread): add reversible inbox-state commands#69
gnapse wants to merge 3 commits intomainfrom
ernesto/inbox-state-undo

gnapse commented Mar 3, 2026 •

edited

Loading

Uh oh!

scottlovegrove commented Mar 21, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

gnapse commented Apr 6, 2026

Uh oh!

doistbot left a comment

Uh oh!

doistbot Apr 6, 2026

Uh oh!

doistbot Apr 6, 2026

Uh oh!

doistbot Apr 6, 2026

Uh oh!

scottlovegrove Apr 7, 2026

Uh oh!

scottlovegrove Apr 7, 2026

Uh oh!

gnapse Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		\`--notify\` automatically resolves IDs: group IDs are routed to the \`groups\` API field, user IDs to \`recipients\`. No special syntax needed.

		Migration note: \`tw thread done\` is reversible via \`tw thread reopen\`.

Conversation

gnapse commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Behavior

Docs And Tests

Verification

Notes

Uh oh!

scottlovegrove commented Mar 21, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

gnapse commented Apr 6, 2026

Uh oh!

doistbot left a comment

Choose a reason for hiding this comment

Uh oh!

doistbot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

doistbot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

doistbot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

scottlovegrove Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

scottlovegrove Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

gnapse Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gnapse commented Mar 3, 2026 •

edited

Loading