Skip to content

Conversation

@frankieyan
Copy link
Member

This PR documents the release process using release-please and conventional commits.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan frankieyan requested a review from a team as a code owner February 5, 2026 06:51
@frankieyan frankieyan requested review from Bloomca and removed request for a team February 5, 2026 06:51
@frankieyan frankieyan added the 👀 Show PR PR must be reviewed before or after merging label Feb 5, 2026
Copy link

@doist-bot doist-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a helpful 'Releasing' section to the README, clarifying the release process using release-please and conventional commits, which significantly enhances understanding of how releases are triggered and managed. To ensure full clarity, it would be beneficial to expand the section on major releases to explicitly mention the BREAKING CHANGE: footer as an additional trigger for major version increments.


## Releasing

This project uses [release-please](https://github.com/googleapis/release-please) to automate releases. Commits merged to `main` with `fix:` trigger patch releases, `feat:` triggers minor releases, and `feat!:` or `fix!:` triggers major releases.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] This sentence states major releases are triggered only by feat!: or fix!:. With conventional commits/release-please, a breaking change can also be indicated by a BREAKING CHANGE: footer even without the !, which would still trigger a major release. This doc would mislead for commits that use the footer form; consider mentioning BREAKING CHANGE as another major trigger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footers are for multiple entries in a single commit/PR. Let's keep it simple and go with the simple prefixes: https://github.com/googleapis/release-please#how-should-i-write-my-commits

@frankieyan frankieyan merged commit c21aca4 into main Feb 5, 2026
2 checks passed
@frankieyan frankieyan deleted the frankie/add-releasing-docs branch February 5, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant