Skip to content

refactor: switch from .mts to .ts file extensions #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankieyan merged 1 commit into from
Feb 4, 2026
Merged

refactor: switch from .mts to .ts file extensions #56

frankieyan merged 1 commit into from
Feb 4, 2026

Conversation

@frankieyan
Copy link
Member

@frankieyan frankieyan commented Feb 4, 2026 •
edited
Loading

Since the project uses ESM via "type": "module" in package.json, the explicit .mts extension is redundant. This simplifies the developer experience with standard .ts extensions and improves tooling compatibility.

Import paths are still using .js because:

  • .ts requires allowImportingTsExtensions: true + noEmit: true or a bundler
  • Extension-less requires a bundler (esbuild, tsx, etc.) or moduleResolution: "bundler"

Test plan

  • CI passing

@frankieyan @claude
refactor: switch from .mts to .ts file extensions
ba269eb 
Since the project uses ESM via "type": "module" in package.json,
the explicit .mts extension is redundant. This simplifies the
developer experience with standard .ts extensions and improves
tooling compatibility.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan frankieyan marked this pull request as ready for review February 4, 2026 19:31
@frankieyan frankieyan requested a review from a team as a code owner February 4, 2026 19:31
@frankieyan frankieyan requested review from pauloslund and removed request for a team February 4, 2026 19:31
@frankieyan frankieyan added the 👀 Show PR PR must be reviewed before or after merging label Feb 4, 2026
doist-bot[bot]
doist-bot bot reviewed Feb 4, 2026
View reviewed changes
Copy link

@doist-bot doist-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for simplifying the file structure by switching from .mts to the standard .ts extension. This is a nice improvement that leverages our existing ESM configuration and should improve tooling compatibility.

@frankieyan frankieyan merged commit 6f03d6e into main Feb 4, 2026
4 checks passed
@frankieyan frankieyan deleted the frankie/esm-default-ts-ext branch February 4, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pauloslund pauloslund Awaiting requested review from pauloslund pauloslund is a code owner automatically assigned from Doist/frontend-product

1 more reviewer

@doist-bot doist-bot[bot] doist-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@frankieyan