SOV-5215: add Amount renderer component #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sovryn-layer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new AmountRenderer component to standardize the display of numeric values with formatting, tooltips, and copy functionality across the Money Market interface. The component provides consistent decimal formatting, prefix/suffix support, and an optional tooltip with copy-to-clipboard functionality.
- Introduces
AmountRenderercomponent with configurable formatting options - Replaces hardcoded value formatting with the new component across multiple tables and statistics
- Updates type definitions to use numeric types instead of pre-formatted strings
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web-app/src/components/ui/amount-renderer.tsx | New component for standardized amount display with formatting and copy functionality |
| apps/web-app/src/components/MoneyMarket/components/TopPanel/TopPanel.tsx | Updated to use AmountRenderer for net worth, APY, and health factor display |
| apps/web-app/src/components/MoneyMarket/components/PoolPositionStat/PoolPositionStat.tsx | Changed value prop type from string/number to ReactNode to support AmountRenderer |
| apps/web-app/src/components/MoneyMarket/components/LendPositionsList/components/AssetsTable/AssetsTable.constants.tsx | Updated balanceUsd from string to number format |
| apps/web-app/src/components/MoneyMarket/components/LendPositionsList/LendPositionsList.types.tsx | Changed balanceUsd type from string to number |
| apps/web-app/src/components/MoneyMarket/components/LendPositionsList/LendPositionsList.tsx | Replaced formatted strings with AmountRenderer components |
| apps/web-app/src/components/MoneyMarket/components/LendAssetsList/components/AssetsTable/AssetsTable.tsx | Updated balance and APY display to use AmountRenderer |
| apps/web-app/src/components/MoneyMarket/components/LendAssetsList/components/AssetsTable/AssetsTable.constants.tsx | Added balanceUsd numeric values to asset data |
| apps/web-app/src/components/MoneyMarket/components/LendAssetsList/LendAssetsList.types.tsx | Added optional balanceUsd number field |
| apps/web-app/src/components/MoneyMarket/components/BorrowPositionsList/components/AssetsTable/AssetsTable.tsx | Updated to use AmountRenderer for balance and APY display |
| apps/web-app/src/components/MoneyMarket/components/BorrowPositionsList/components/AssetsTable/AssetsTable.constants.tsx | Changed balanceUsd from string to number format |
| apps/web-app/src/components/MoneyMarket/components/BorrowPositionsList/BorrowPositionsList.types.tsx | Updated balanceUsd type from string to number |
| apps/web-app/src/components/MoneyMarket/components/BorrowPositionsList/BorrowPositionsList.tsx | Replaced formatted strings with AmountRenderer components |
| apps/web-app/src/components/MoneyMarket/components/BorrowAssetsList/components/AssetsTable/AssetsTable.constants.tsx | Updated balanceUsd from string to number format |
| apps/web-app/src/components/MoneyMarket/components/BorrowAssetsList/BorrowAssetsList.types.tsx | Changed balanceUsd type from string to number |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c/components/MoneyMarket/components/LendPositionsList/components/AssetsTable/AssetsTable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/MoneyMarket/components/BorrowAssetsList/components/AssetsTable/AssetsTable.tsx
Outdated
Show resolved
Hide resolved
…sList/components/AssetsTable/AssetsTable.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c/components/MoneyMarket/components/LendPositionsList/components/AssetsTable/AssetsTable.tsx
Outdated
Show resolved
Hide resolved
...rc/components/MoneyMarket/components/BorrowAssetsList/components/AssetsTable/AssetsTable.tsx
Show resolved
Hide resolved
creed-victor
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.