Skip to content

[ENG-1637] Add Hover info text on base icon#962

Open
trangdoan982 wants to merge 1 commit intomainfrom
worktree-eng-1637-add-hover-info-text-on-base-icon
Open

[ENG-1637] Add Hover info text on base icon#962
trangdoan982 wants to merge 1 commit intomainfrom
worktree-eng-1637-add-hover-info-text-on-base-icon

Conversation

@trangdoan982
Copy link
Copy Markdown
Member

@trangdoan982 trangdoan982 commented Apr 14, 2026

Before:
image

After:
image


Open with Devin

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 14, 2026

@supabase
Copy link
Copy Markdown

supabase bot commented Apr 14, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@trangdoan982 trangdoan982 force-pushed the worktree-eng-1637-add-hover-info-text-on-base-icon branch from 2bec661 to 6c5cdc4 Compare April 14, 2026 20:51
@trangdoan982 trangdoan982 requested a review from mdroidian April 14, 2026 20:53
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Comment on lines +161 to +164
ref={(el) => {
if (el)
setTooltip(el, `Create Base view for ${nodeType.name} nodes`);
}}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip uses nodeType.name directly, but line 158 shows that nodeType.name can be falsy (using nodeType.name || "Unnamed Node Type"). When nodeType.name is undefined/null/empty, the tooltip will display inconsistent text like "Create Base view for undefined nodes" while the UI shows "Unnamed Node Type".

Fix:

ref={(el) => {
  if (el) {
    const name = nodeType.name || "Unnamed Node Type";
    setTooltip(el, `Create Base view for ${name} nodes`);
  }
}}
Suggested change
ref={(el) => {
if (el)
setTooltip(el, `Create Base view for ${nodeType.name} nodes`);
}}
ref={(el) => {
if (el)
const name = nodeType.name || "Unnamed Node Type";
setTooltip(el, `Create Base view for ${name} nodes`);
}}

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Copy link
Copy Markdown
Member

@mdroidian mdroidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should deal with the graphite suggestion, or maybe handle null nodeType.name higher up the chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants