[ENG-1271] Implement filter, search, sort designs in clipboard#900
[ENG-1271] Implement filter, search, sort designs in clipboard#900trangdoan982 wants to merge 6 commits intomainfrom
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Let's match the UI designs more closely:
- Nodes should have their node colors (you can take this code from elsewhere in the project, eg Canvas Drawer)
- Search on left, filters/sort on right
- Show "Clear Filters" but keep it disabled. This is to be consistent with other components and help remove jank and it won't come as a surprise to users
- Filter button should have the button design as seen in the image
- Remove search layout jank
https://www.loom.com/share/3547f91eff7e4ffa95da825a29184954
|
@mdroidian Loom is down so this is the recorded test for the new filter according to Johnny's new design and your feedback |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Let's move getting the node type up the chain so that we don't duplicate the findDiscourseNode call
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
trangdoan982
force-pushed
the
eng-1271-implement-filtersearchsort-designs-in-clipboard
branch
from
0898926 to
4a375bf
Compare
2 participants
https://www.loom.com/share/ca48bea531b44511ac951363dd996971