Skip to content

Make query builder results dark-mode responsive #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mattakamatsu wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make query builder results dark-mode responsive #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions apps/roam/src/components/results-view/Kanban.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ const KanbanCard = (card: {
hidden={!isDragHandle}
/>
<div
className={`mb-3 rounded-xl bg-white p-4 ${
isDragHandle ? "" : "cursor-pointer hover:bg-gray-200"
className={`mb-3 rounded-xl bg-white dark:bg-gray-800 p-4 ${
isDragHandle ? "" : "cursor-pointer hover:bg-gray-200 dark:hover:bg-gray-700"
}`}
>
<div className="card-display-value">
Expand Down Expand Up @@ -609,17 +609,12 @@ const Kanban = ({
width: PSEUDO_CARD_WIDTH,
}}
>
<div className="mb-3 cursor-move rounded-xl bg-white p-4 shadow-lg">
<div className="font-semibold text-gray-800">Card</div>
<div className="mb-3 cursor-move rounded-xl bg-white dark:bg-gray-800 p-4 shadow-lg">
<div className="font-semibold text-gray-800 dark:text-gray-200">Card</div>
</div>
</div>
{showLegend === "Yes" && (
<div
className="w-full p-4"
style={{
background: "#eeeeee80",
}}
>
<div className="w-full p-4 bg-gray-200/50 dark:bg-gray-700/50">
<div className="mr-4 inline-block">
<span className="font-bold">Group By:</span>
<span> {columnKey}</span>
Expand All @@ -642,7 +637,7 @@ const Kanban = ({
return (
<div
key={col}
className="flex-shrink-1 roamjs-kanban-column flex max-w-2xl flex-col gap-2 rounded-2xl bg-gray-100 p-4"
className="flex-shrink-1 roamjs-kanban-column flex max-w-2xl flex-col gap-2 rounded-2xl bg-gray-100 dark:bg-gray-800 p-4"
data-column={col}
style={{ minWidth: "24rem" }}
>
Expand Down Expand Up @@ -744,8 +739,7 @@ const Kanban = ({
</div>
</div>
<div
className={`p-0 ${!showInterface ? "hidden" : ""}`}
style={{ background: "#eeeeee80" }}
className={`p-0 bg-gray-200/50 dark:bg-gray-700/50 ${!showInterface ? "hidden" : ""}`}
>
<div
className="flex items-center gap-4"
Expand Down
2 changes: 1 addition & 1 deletion apps/roam/src/components/results-view/ResultsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ const ResultsTable = ({
data-parent-uid={parentUid}
{...tableProps}
>
<thead style={{ background: "#eeeeee80" }}>
<thead className="bg-gray-200/50 dark:bg-gray-700/50">
<tr style={{ visibility: !showInterface ? "collapse" : "visible" }}>
{visibleColumns.map((c) => (
<ResultHeader
Expand Down
23 changes: 7 additions & 16 deletions apps/roam/src/components/results-view/ResultsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,12 +516,7 @@ const ResultsView: ResultsViewComponent = ({
)}

{showSearchFilter && (
<div
className="w-full p-4"
style={{
background: "#eeeeee80",
}}
>
<div className="w-full p-4 bg-gray-200/50 dark:bg-gray-700/50">
<InputGroup
fill={true}
placeholder="Search"
Expand Down Expand Up @@ -1035,22 +1030,22 @@ const ResultsView: ResultsViewComponent = ({
text="Column Views"
/>
<HTMLTable className="min-w-full">
<thead className="bg-gray-50">
<thead className="bg-gray-50 dark:bg-gray-800">
<tr>
<th className="text-xs font-medium uppercase tracking-wider !text-gray-500">
<th className="text-xs font-medium uppercase tracking-wider !text-gray-500 dark:!text-gray-400">
Column
</th>
<th className="text-xs font-medium uppercase tracking-wider !text-gray-500">
<th className="text-xs font-medium uppercase tracking-wider !text-gray-500 dark:!text-gray-400">
View
</th>
{showColumnViewOptions && (
<th className="text-xs font-medium uppercase tracking-wider !text-gray-500">
<th className="text-xs font-medium uppercase tracking-wider !text-gray-500 dark:!text-gray-400">
Options
</th>
)}
</tr>
</thead>
<tbody className="divide-y divide-gray-200 bg-white">
<tbody className="divide-y divide-gray-200 dark:divide-gray-700 bg-white dark:bg-gray-900">
{views.map(({ column, mode, value }, i) => (
<tr key={i}>
<td className="whitespace-nowrap">{column}</td>
Expand Down Expand Up @@ -1414,11 +1409,7 @@ const ResultsView: ResultsViewComponent = ({
</div>
)}
<div
style={
!showInterface
? { display: "none" }
: { background: "#eeeeee80" }
}
className={`bg-gray-200/50 dark:bg-gray-700/50 ${!showInterface ? "hidden" : ""}`}
>
<div
className="flex items-center justify-between px-1 text-xs"
Expand Down
19 changes: 19 additions & 0 deletions apps/roam/src/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,23 @@

.fuzzy-select-input-popover .bp3-popover-target {
width: 100%;
}

/* Dark mode overrides for query builder */
.bp3-dark .roamjs-query-hightlighted-result {
background: #b8860b;
}

.bp3-dark .roamjs-query-results-view ul::-webkit-scrollbar-thumb {
background: #555;
}

.bp3-dark .roamjs-extra-row td {
background-color: #30404d;
}

.bp3-dark .sidebar-title-button:hover,
.bp3-dark .sidebar-title-button-add:hover {
background-color: #f5f8fa;
color: #10161a;
}
3 changes: 2 additions & 1 deletion apps/roam/tailwind.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
import type { Config } from "tailwindcss";
import sharedConfig from "@repo/tailwind-config";

const config: Pick<Config, "content" | "presets"> = {
const config: Pick<Config, "content" | "presets" | "darkMode"> = {
content: [],
presets: [sharedConfig],
darkMode: ["class", ".bp3-dark"],
};

export default config;
Loading