Switch to approachable concurrency + default to main actor isolation#2422
Switch to approachable concurrency + default to main actor isolation#2422
Conversation
|
@codex review |
Dimillian
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b312bedf2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8b7f84332
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Moved stream event decoding into a new StreamEventDecoder actor for sequential processing and improved error handling. Updated event emission methods to be public and streamlined error logging for decoding failures.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Part 1
Summary
NotificationServiceoverrides and helpers with nonisolated base APIs under main-actor-by-defaultMainActorTests
mcp__XcodeBuildMCP__build_simAccountTestsModelsTestsTimelineTestsEnvTestsPart 2
Summary
MainActorwhere needed (image resize, media refresh)Testing
mcp__XcodeBuildMCP__build_simAccountTestsStatusKitTestsTimelineTests