Fix filter context handling for notifications and timelines#2416
Merged
Fix filter context handling for notifications and timelines#2416
Conversation
Ensure instance-side filter contexts are respected across timelines, account views, detail threads, explore, and notifications. Notifications now drop hide-completely items while still advancing markers to prevent unread badges, and policy changes refresh the list after dismissing the sheet. Localize filtered notifications selection UI and policy subtitles. Closes: #639, #2211, #2210, #2227
Use localization keys for notifications policy subtitles and moderated accounts label.
Owner
Author
|
@codex review this |
Owner
Author
|
@codex review this in accordance with the mastodon instance side filter documentation and see if it honors it correctly |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Added a Task in the TimelineViewModel initializer to set the filter context on the datasource asynchronously. This ensures the datasource is configured with the correct filter context upon initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details by issue
Testing