Add DirectSR (D3D12) super resolution implementation#780
Open
MikhailGorobets wants to merge 1 commit intoDiligentGraphics:super_resolution2from
Open
Add DirectSR (D3D12) super resolution implementation#780MikhailGorobets wants to merge 1 commit intoDiligentGraphics:super_resolution2from
MikhailGorobets wants to merge 1 commit intoDiligentGraphics:super_resolution2from
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TheMostDiligent
force-pushed
the
super_resolution2
branch
from
1764aac to
9c44db2
Compare
TheMostDiligent
requested changes
Mar 15, 2026
MikhailGorobets
force-pushed
the
super_resolution2
branch
20 times, most recently
from
fb1e941 to
a22addd
Compare
Comment on lines
+181
to
+195
| if (NVSDK_NGX_SUCCEED(ExtResult) && ExtCount > 0 && pExtensions != nullptr) | ||
| { | ||
| /* TODO: Need to implement IsExtensionEnabled in VulkanUtilities::LogicalDevice | ||
| const VulkanUtilities::LogicalDevice& LogicDevice = pDeviceVk->GetLogicalDevice(); | ||
| for (Uint32 ExtensionIdx = 0; ExtensionIdx < ExtCount; ++ExtensionIdx) | ||
| { | ||
| if (!LogicDevice.IsExtensionEnabled(pExtensions[ExtensionIdx].extensionName)) | ||
| { | ||
| LOG_ERROR_AND_THROW("DLSS requires Vulkan device extension '", pExtensions[ExtensionIdx].extensionName, | ||
| "' which is not supported by the physical device. " | ||
| "Enable it via EngineVkCreateInfo::ppDeviceExtensionNames."); | ||
| } | ||
| } | ||
| */ | ||
| } |
Check notice
Code scanning / CodeQL
Futile conditional Note
Comment on lines
+183
to
+194
| /* TODO: Need to implement IsExtensionEnabled in VulkanUtilities::LogicalDevice | ||
| const VulkanUtilities::LogicalDevice& LogicDevice = pDeviceVk->GetLogicalDevice(); | ||
| for (Uint32 ExtensionIdx = 0; ExtensionIdx < ExtCount; ++ExtensionIdx) | ||
| { | ||
| if (!LogicDevice.IsExtensionEnabled(pExtensions[ExtensionIdx].extensionName)) | ||
| { | ||
| LOG_ERROR_AND_THROW("DLSS requires Vulkan device extension '", pExtensions[ExtensionIdx].extensionName, | ||
| "' which is not supported by the physical device. " | ||
| "Enable it via EngineVkCreateInfo::ppDeviceExtensionNames."); | ||
| } | ||
| } | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
…), MetalFX (Metal)
MikhailGorobets
force-pushed
the
super_resolution2
branch
from
a22addd to
7c37696
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.