Introduce DiamondDS theme foundation and component updates#177
Open
zoharma wants to merge 9 commits into
Open
Conversation
Introduced the initial Diamond Design System theme foundation, including semantic colour roles, light/dark mode support, CSS variable mappings, and integration with the MUI theming architecture. Updated component styling, states, and overrides across inputs, buttons, checkboxes, radio buttons, overlays, borders, and theme icons. Fixed issues Prettify
Mini intro and foundations pages for principles, colour, and typography
akademy
reviewed
May 11, 2026
| @@ -1,11 +1,7 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
This doesn't seem to have any changes except cosmetic.
| export * from "./themes/BaseTheme"; | ||
| export * from "./themes/DiamondTheme"; | ||
| export * from "./themes/DiamondOldTheme"; | ||
| export * from "./themes/DiamondDSTheme"; |
Member
There was a problem hiding this comment.
Is there some reason why we've removed the old theme?
Author
There was a problem hiding this comment.
I don't see that it's being used by the dropdown. We can keep it...
Member
There was a problem hiding this comment.
It's not available in Storybook, but it can be used downstream. It's just there in case someone says "we loved the other one"! But hopefully, no one will use it!
akademy
reviewed
May 12, 2026
zoharma
force-pushed
the
zma/new-dstheme
branch
11 times, most recently
from
b5b07cd to
e28b014
Compare
…iguration support Following suggestion of simplification by @akademy. - Updated theme mode handling to use MUI colour scheme classes - Removed previous data-mode logic - Introduced back System settings option and a way to switch to it Revert "Refactor Storybook theme handling and introduce Diamond DS theme configuration support" This reverts commit 3784323. Reapply "Refactor Storybook theme handling and introduce Diamond DS theme configuration support" This reverts commit a845238.
…eme configuration support" This reverts commit 8b304fd.
zoharma
force-pushed
the
zma/new-dstheme
branch
3 times, most recently
from
f05507c to
4664afc
Compare
zoharma
force-pushed
the
zma/new-dstheme
branch
2 times, most recently
from
de3b23e to
603db8a
Compare
- document theme architecture and semantic token model - simplified repeated conventions across intents - clarify action intent, status intent, and brand usage - add dedicated BrandPaletteColor typing with fixed brand roles - improve helper documentation and component override comments - keep CSS variables as the source of truth for theme roles - remove global Paper override - update theme colours to use grey primitives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced the initial Diamond Design System theme foundation, including semantic colour roles, light/dark mode support, CSS variable mappings, and integration with the MUI theming architecture.
Updated component styling, states, and overrides across inputs, buttons, checkboxes, radio buttons, overlays, borders, and theme icons.