Skip to content

refactor: Add error extensions to AuthError#275

Open
shree-iyengar-dls wants to merge 4 commits intomainfrom
add_error_extensions
Open

refactor: Add error extensions to AuthError#275
shree-iyengar-dls wants to merge 4 commits intomainfrom
add_error_extensions

Conversation

@shree-iyengar-dls
Copy link
Copy Markdown

Improving numtracker auth error messages

@shree-iyengar-dls shree-iyengar-dls requested a review from tpoliaw May 8, 2026 14:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.08%. Comparing base (a25367f) to head (873428b).

Files with missing lines Patch % Lines
src/graphql/auth.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   76.35%   76.08%   -0.28%     
==========================================
  Files          13       13              
  Lines        1937     1944       +7     
==========================================
  Hits         1479     1479              
- Misses        458      465       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw
Copy link
Copy Markdown
Collaborator

tpoliaw commented May 8, 2026

Looks good but could do with a couple of tests to make sure the errors look as expected.

And numtracker doesn't use conventional commits

@shree-iyengar-dls
Copy link
Copy Markdown
Author

Yup, just adding some tests now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants