Reduce area of tiled API being wrapped#92
Draft
tpoliaw wants to merge 3 commits into
Draft
Conversation
Contributor
tpoliaw
commented
Dec 8, 2025
- Remove derives from types that no longer need them
- Remove Links struct and associated fields
- Reduce visibility of fields where possible
We're no longer exposing tiled data exactly as recieved so it no longer needs to implement async-graphql's traits.
Make it easier to reason about which fields are being used and which are likely to be removable.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 52.64% 51.00% -1.65%
==========================================
Files 13 13
Lines 585 600 +15
==========================================
- Hits 308 306 -2
- Misses 277 294 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.