Tidy up PinTipDetection

[noemifrisina]

Part of i19-bluesky#116

• Tidy up pin tip detection utils following I19 testing
• Have the scan direction as input argument instead of reading json file

Instructions to reviewer on how to test:

1. Run tests

Checks for reviewer

• Would the PR title make sense to a scientist on a set of release notes
• If a new device has been added does it follow the standards
• If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
• Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (1d5983f) to head (17a5d60).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1880   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         305      305           
  Lines       11519    11522    +3     
=======================================
+ Hits        11408    11411    +3     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[DominicOram]

Thanks, some suggestions. Basically this goes half way to decoupling it but not finishing the job, which sort of feels worse

[DominicOram]

Could: If we're going to do this then we might as well decouple it entirely and set the enum to be:

class ScanDirections(Enum):
    FORWARD = auto()
    REVERSE = auto()

[DominicOram]

Could: You can just set the type of this to be ScanDirections then you don't need to do the cast below

[noemifrisina]

I tried that in the first instance and got turned around by various typing issues - which is also how a random #type: ignore appeared and was forgotten. Trying again after I address the rest of the comments

[DominicOram]

Should: This is still relying on the value of the enum so if we want to decouple them it should be if self.scan_direction == ScanDirections.FORWARD

[DominicOram]

Should: Why the type ignore here?

[DominicOram]

Great, thank you!