Open
Conversation
…isfy the concepts
…concepts - Move codomain_and_*Pdf and domain_and_*Pdf structs into their own warp_and_pdf.hlsl header - Keeping quotient_and_pdf.hlsl focused on importance sampling quotients for BxDFs - Add SampleWithPDF, SampleWithRcpPDF, and SampleWithDensity concepts to validate sample types - Used concept composition (NBL_CONCEPT_REQ_TYPE_ALIAS_CONCEPT) to build ResamplableSampler on TractableSampler and BijectiveSampler on ResamplableSampler
… projected/spherical triangle
… tri to match concepts
…ard/backward pdfs + inverse generate
…ds to match concept
…s to match concept (inverse is sketchy), invert concentric mapping
…ncepts, prevent NaN in spherical rectangle, few refactors
# Conflicts: # examples_tests
# Conflicts: # examples_tests # include/nbl/builtin/hlsl/sampling/bilinear.hlsl # include/nbl/builtin/hlsl/sampling/box_muller_transform.hlsl # include/nbl/builtin/hlsl/sampling/linear.hlsl # include/nbl/builtin/hlsl/sampling/projected_spherical_triangle.hlsl # include/nbl/builtin/hlsl/sampling/spherical_rectangle.hlsl # include/nbl/builtin/hlsl/sampling/spherical_triangle.hlsl
…ampler-concepts # Conflicts: # include/nbl/builtin/hlsl/sampling/bilinear.hlsl # include/nbl/builtin/hlsl/sampling/box_muller_transform.hlsl # include/nbl/builtin/hlsl/sampling/linear.hlsl # include/nbl/builtin/hlsl/sampling/projected_spherical_triangle.hlsl # include/nbl/builtin/hlsl/sampling/spherical_rectangle.hlsl # include/nbl/builtin/hlsl/sampling/spherical_triangle.hlsl # include/nbl/builtin/hlsl/shapes/spherical_rectangle.hlsl # include/nbl/builtin/hlsl/shapes/spherical_triangle.hlsl
# Conflicts: # examples_tests
# Conflicts: # examples_tests
…() for floats, separeted SMaxError into a separate file with support to other types than float
# Conflicts: # examples_tests
Pick up the follow-up O1experimental VariablePointers trim that stops treating ordinary OpStore instructions as a reason to keep the capability alive. This keeps the sampler branch aligned with the updated DXC and SPIRV-Tools lane for package rebuilding and CI validation.
Restore the clamp on cosAngleAlongBC_s before the BC slerp. This removes the remaining narrow numeric drift seen in EX37 after the VariablePointers toolchain fix and brings the sampler branch workload back to a full pass in PACKAGE mode.
- `getSumOfArccosMinusPi()` and `getClampedSumOfArccosMinusPi()` a good way to prevent catastrophic cancellation and NaNs - `sincos()` now uses sin and cos, no tricks, faster and more accurate - linear and bilinear are simpler and faster - spherical triangle templated version that is bijective (will probably remove all this boilerplate cus it doesn't make a perf difference)
…ing/Nabla into sampler-concepts # Conflicts: # include/nbl/builtin/hlsl/sampling/spherical_triangle.hlsl
# Conflicts: # tools/nsc/manifests/nsc-windows-x64-release.tag # tools/nsc/manifests/nsc-windows-x64-release/exe/tools/nsc/bin/build-info.json.dvc # tools/nsc/manifests/nsc-windows-x64-release/exe/tools/nsc/bin/nsc.exe.dvc # tools/nsc/manifests/nsc-windows-x64-release/runtime/nbl/3rdparty/dxc/dxcompiler.dll.dvc # tools/nsc/manifests/nsc-windows-x64-release/runtime/nbl/Nabla.dll.dvc
# Conflicts: # examples_tests # include/nbl/builtin/hlsl/path_tracing/gaussian_filter.hlsl # include/nbl/builtin/hlsl/sampling/basic.hlsl # include/nbl/builtin/hlsl/sampling/box_muller_transform.hlsl
…pressure and fix some warnings
…ng_serialized_mesh Unflip the x axis for serialized mesh
# Conflicts: # examples_tests
…ath_tracer_beauty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MErges #1001 opened for CI purposes