Added support for VK_KHR_PIPELINE_EXECUTABLE_PROPERTIES#1003
Open
karimsayedre wants to merge 4 commits intomasterfrom
Open
Added support for VK_KHR_PIPELINE_EXECUTABLE_PROPERTIES#1003karimsayedre wants to merge 4 commits intomasterfrom
karimsayedre wants to merge 4 commits intomasterfrom
Conversation
…cks, `getPipelineExecutableProperties_impl` overloads with one helper function
karimsayedre
commented
Feb 22, 2026
… to pipeline base
karimsayedre
commented
Feb 25, 2026
# Conflicts: # examples_tests
Comment on lines
+1196
to
+1201
| if (info.flags.hasFlags(IGPUComputePipeline::SCreationParams::FLAGS::CAPTURE_STATISTICS)) | ||
| { | ||
| pipeline->populateExecutableInfo(info.flags.hasFlags(IGPUComputePipeline::SCreationParams::FLAGS::CAPTURE_INTERNAL_REPRESENTATIONS)); | ||
| if (pipeline->getExecutableInfo().empty()) | ||
| m_logger.log("Driver returned 0 executables for pipeline created with CAPTURE_STATISTICS flag. This pipeline type may not be supported by the driver's VK_KHR_pipeline_executable_properties implementation.", system::ILogger::ELL_WARNING); | ||
| } |
There was a problem hiding this comment.
there's shared validation of pipeline creation parameters we do in ILogicalDevice, put that there
| if (pipeline->getExecutableInfo().empty()) | ||
| m_logger.log("Driver returned 0 executables for pipeline created with CAPTURE_STATISTICS flag. This pipeline type may not be supported by the driver's VK_KHR_pipeline_executable_properties implementation.", system::ILogger::ELL_WARNING); | ||
| } | ||
| output[i] = std::move(pipeline); |
There was a problem hiding this comment.
why not call into populateExecutableInfo from the constructors ?
|
|
||
| inline VkPipeline getInternalObject() const { return m_vkPipeline; } | ||
|
|
||
| void populateExecutableInfo(bool includeInternalRepresentations); |
There was a problem hiding this comment.
add it as a pure virtual protected function in IGPUPipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes: