Skip to content

fix(jetsocat): embed Windows icon and version metadata#1793

Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 2 commits into
masterfrom
jetsocat-icon
Open

fix(jetsocat): embed Windows icon and version metadata#1793
Marc-André Moreau (mamoreau-devolutions) wants to merge 2 commits into
masterfrom
jetsocat-icon

Conversation

@mamoreau-devolutions
Copy link
Copy Markdown
Contributor

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) commented May 22, 2026

Embeds the Devolutions Gateway icon and Windows version metadata into jetsocat.exe on Windows so the binary has branded iconography and standard file properties in Explorer.

image

this will make automatic app icon extraction easier for jetsocat

@mamoreau-devolutions
Copy link
Copy Markdown
Contributor Author

Implementation notes:

  • Adds a Windows-only build script to jetsocat and compiles both a generated VERSIONINFO resource and a static icon resource.
  • Reuses package/WindowsManaged/Resources/DevolutionsGateway.ico so jetsocat.exe gets the existing Devolutions Gateway icon without duplicating assets.
  • Uses CARGO_PKG_VERSION to generate the file and product version metadata embedded into the executable.
  • Adds embed-resource as a Windows-only build dependency and updates Cargo.lock accordingly.

Validation:

  • cargo build -p jetsocat -q

@github-actions
Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants