Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Pull request overview
This pull request improves the Desktop Agent application with better DPI awareness, dark theme support, resource reorganization, and configuration-based feature visibility. The changes modernize the UI to work better on high-DPI displays and add support for Windows dark mode while making the PEDM features conditionally visible based on configuration.
Changes:
- Added DPI awareness configuration through app.manifest and App.config for better high-resolution display support
- Implemented dark theme support with automatic detection based on Windows theme settings
- Reorganized resources into separate files (StaticResources for non-localizable strings, ImageResources for graphics, Resources for localizable strings)
- Corrected installer feature assignments so desktop agent files are properly associated with AGENT_FEATURE instead of PEDM_FEATURE
- Added configuration loading to conditionally display PEDM profiles only when enabled
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| package/AgentWindowsManaged/Program.cs | Fixed feature assignment for desktop agent directory and registry entry from PEDM_FEATURE to AGENT_FEATURE |
| dotnet/DesktopAgent/app.manifest | Added application manifest with DPI awareness and Windows 10 compatibility settings |
| dotnet/DesktopAgent/Utils/UI.cs | Added utility methods for dark theme detection and immersive dark mode application |
| dotnet/DesktopAgent/Utils/Service.cs | Added utility method to check if a Windows service is running |
| dotnet/DesktopAgent/Utils/Config.cs | Added configuration loading from agent.json with support for feature flags |
| dotnet/DesktopAgent/Properties/StaticResources.resx | New resource file for non-localizable static strings (product and vendor names) |
| dotnet/DesktopAgent/Properties/StaticResources.Designer.cs | Auto-generated designer code for static resources |
| dotnet/DesktopAgent/Properties/Resources.resx | Removed image resources and static strings, added new menu items for service status |
| dotnet/DesktopAgent/Properties/Resources.fr.resx | Added French translations for new menu items |
| dotnet/DesktopAgent/Properties/Resources.Designer.cs | Updated to reflect resource changes and version bump to 18.0.0.0 |
| dotnet/DesktopAgent/Properties/ImageResources.resx | New resource file dedicated to image resources (icon and logo) |
| dotnet/DesktopAgent/Properties/ImageResources.Designer.cs | Auto-generated designer code for image resources |
| dotnet/DesktopAgent/Program.cs | Updated to load configuration, check service status, and conditionally display PEDM menu based on config |
| dotnet/DesktopAgent/DesktopAgent.csproj | Added manifest reference, ServiceProcess reference, and new resource file definitions |
| dotnet/DesktopAgent/App.config | Added DPI awareness configuration for Windows Forms |
| dotnet/DesktopAgent/About.cs | Refactored About dialog with DPI awareness, dark theme support, and improved layout using TableLayoutPanel |
Files not reviewed (3)
- dotnet/DesktopAgent/Properties/ImageResources.Designer.cs: Language not supported
- dotnet/DesktopAgent/Properties/Resources.Designer.cs: Language not supported
- dotnet/DesktopAgent/Properties/StaticResources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
49e92e3 to
da04576
Compare
The desktop companion app for Agent is now deployed alongside the main Agent feature, instead of exclusively for PEDM. This gives the user some visibility that the Agent is installed and running and provides basic information (e.g. an About window).
The desktop companion app also gets several upgrades: