[MacOS] Fix inconsistent response to custom height across controls #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apman
force-pushed
the
MacOS/inconsistent-fixed-height-behaviour
branch
from
704e2c7 to
2b4439e
Compare
apman
force-pushed
the
MacOS/inconsistent-fixed-height-behaviour
branch
from
2b4439e to
909f349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ ❗ (Slightly) Braking Change! Discuss with Xavier before merging! ❗ ❗
This fixes a number of inconsistencies across MacOS controls in how they respond to explicit height settings.
Before: some controls did not respond at all, some grew to the set size but lost their margins, potentially leading to focus highlight being cut off, some grew overall to the requested size leaving room for the margins (so the visible size is 3px less)
After: I have now taken the latter approach for all controls.
While it might seem slightly confusing that a "30px" control has a visible height of 27px, it guarantees that the control is self-contained and won't visually bleed over other controls or get clipped unexpectedly.
Consumers will need to account for the margin (e.g. set
Height="33"to achieve 30 for the unfocussed visual appearance), or don't set a height at all and let the theme dictate the natural size (which is usually the best practice).