Atualização para suportar python 3#3
Open
diegotolentino wants to merge 2 commits intoDeveloperCielo:masterfrom
Open
Atualização para suportar python 3#3diegotolentino wants to merge 2 commits intoDeveloperCielo:masterfrom
diegotolentino wants to merge 2 commits intoDeveloperCielo:masterfrom
Conversation
|
@diegotolentino, esse PR tem um conflito; consegue resolvê-lo e enviar novamente? |
|
@diegotolentino acho que é melhor deixar adaptado para py2 e py3, na verificação de instancia você colocou só o int, mas no python2 tem o long, fiz um PR que verifica a versão e usa o long e int pra py2 e somente o int quando estiver no py3. Achei legal foi que adaptou o exemplo também ! |
|
Ainda não suporta python 3? |
|
Testei e deu tudo certo, vale a consideração do @mrlucascardoso de manter a compatibilidade com o python2 |
mileo
approved these changes
Nov 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pequenas alterações que eram necessárias