AI Assistant: selectAll / deselectAll command ignores selectAllMode#33933
Open
dmirgaev wants to merge 1 commit into
Open
AI Assistant: selectAll / deselectAll command ignores selectAllMode#33933dmirgaev wants to merge 1 commit into
dmirgaev wants to merge 1 commit into
Conversation
…selectAllMode option
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the DataGrid AI assistant command descriptions to ensure “select all / deselect all” requests are routed to the correct command depending on selection.selectAllMode, especially when the user asks for “current/visible page” while selectAllMode = "allPages".
Changes:
- Expanded
selectionByIndexesguidance to cover “select/deselect all on current page” scenarios whenselectAllMode = "allPages". - Refined
selectAll/deselectAlldescriptions to explicitly restrict their use to cases where the user-requested scope matchesselectAllMode.
Comment on lines
+227
to
+229
| description: 'Select rows. Scope depends on selection.selectAllMode: "allPages" (default) selects across every page; "page" selects only the currently rendered page. If a filter is applied, only rows matching the filter are selected. ' | ||
| + 'Use this command ONLY when the scope the user asks for matches selection.selectAllMode: for an unqualified "select all rows" request when selectAllMode is "allPages", or for "select all rows on the current/visible page" when selectAllMode is "page". ' | ||
| + 'If the user asks to select all rows on the CURRENT/VISIBLE page but selectAllMode is "allPages", do NOT use this command (it would select every page) — instead use selectByIndexes with scope "page", mode "select", and indexes listing every row on the current page.', |
Comment on lines
+250
to
+253
| description: 'Deselect rows. Scope depends on selection.selectAllMode: "allPages" (default) deselects across every page; "page" deselects only the currently rendered page. If a filter is applied, only rows matching the filter are deselected. ' | ||
| + 'Use this command ONLY when the scope the user asks for matches selection.selectAllMode: for an unqualified "deselect all rows" request when selectAllMode is "allPages", or for "deselect all rows on the current/visible page" when selectAllMode is "page". ' | ||
| + 'If the user asks to deselect all rows on the CURRENT/VISIBLE page but selectAllMode is "allPages", do NOT use this command (it would deselect every page) — instead use selectByIndexes with scope "page", mode "deselect", and indexes listing every row on the current page. ' | ||
| + 'To clear selection across all pages regardless of selectAllMode, use clearSelection.', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.