DataGrid - AI Assistant: Add AI assistant request abort handling#33538
Open
Alyar666 wants to merge 3 commits intoDevExpress:26_1from
Open
DataGrid - AI Assistant: Add AI assistant request abort handling#33538Alyar666 wants to merge 3 commits intoDevExpress:26_1from
Alyar666 wants to merge 3 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds abort/close handling to the DataGrid AI Assistant chat flow, including a new “request stopped” message and plumbing for abort callbacks, plus the ability to clear the chat’s message store.
Changes:
- Add
onClosedsupport toAIChatand abort the in-flight AI request when the assistant popup is closed. - Add a
clear()API toAIChatand wire “clear chat” to actually remove messages from the underlying store. - Introduce abort callbacks (
onAbort) and a controller-levelprocessingflag to prevent sending messages while a request is in progress.
Reviewed changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/localization/messages/ar.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/bg.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/ca.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/cs.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/da.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/de.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/el.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/en.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/es.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/fa.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/fi.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/fr.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/hu.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/it.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/ja.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/ko.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/lt.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/lv.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/nb.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/nl.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/pl.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/pt.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/ro.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/ru.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/sl.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/sv.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/tr.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/uk.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/vi.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/zh-tw.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/localization/messages/zh.json | Adds dxDataGrid-aiAssistantAbortMessage string. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/types.ts | Extends AIChatOptions with onClosed. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.ts | Fires onClosed on popup hide; adds clear() to wipe/reload the chat data source store. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/ai_chat.test.ts | Adds unit coverage for onClosed and clear(). |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/types.ts | Introduces AIAssistantRequestCallbacks with optional onAbort. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_view.ts | Wires clear-chat + close-abort handlers; blocks new messages while isProcessing(). |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_integration_controller.ts | Wraps the abort function to also invoke callbacks.onAbort. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts | Adds processing flag, abort message handling, and abortRequest() method. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view.test.ts | Adds unit tests for onChatCleared, onClosed, and processing gating. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_view_controller.integration.test.ts | Adds integration coverage for clear-chat and abort-on-close UX. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_integration_controller.integration.test.ts | Adds integration coverage for onAbort callback behavior. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/tests/ai_assistant_controller.test.ts | Adds unit coverage for isProcessing() and abort behavior. |
Comments suppressed due to low confidence (1)
packages/devextreme/js/__internal/grids/grid_core/ai_assistant/ai_assistant_controller.ts:143
sendRequestToAIcreates a Promise but callsthis.aiAssistantIntegrationController?.sendRequest(...)via optional chaining. If the integration controller is not initialized for any reason, this Promise will never resolve/reject andprocessingwill remaintrue. Handle the missing-controller case explicitly (resetprocessingand reject, or avoid wrapping in a new Promise whensendRequestcannot be invoked).
public sendRequestToAI(message: Message): Promise<void> {
const aiMessageId = this.createPendingAIMessage(message);
this.processing = true;
return new Promise((resolve, reject) => {
this.aiAssistantIntegrationController?.sendRequest(message.text, {
onComplete: (response: ExecuteGridAssistantCommandResult): void => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.