Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1042,6 +1042,38 @@ describe('cfg-component option control', () => {
expect((optionsManager as any).setValue).toHaveBeenCalledTimes(1);
});

it('does not crash when option change handler unmounts component (T1327953)', () => {
const optionsManager = new OptionsManagerModule.OptionsManager();
const config = {
name: '',
predefinedOptions: {},
initialOptions: {},
options: {
value: 1,
onValueChange: () => {
optionsManager.dispose();
},
},
templates: [],
configs: {},
configCollections: {},
};

optionsManager.setInstance({
skipOptionsRollBack: false,
option: jest.fn(),
resetOption: jest.fn(),
on: jest.fn(),
off: jest.fn(),
beginUpdate: jest.fn(),
endUpdate: jest.fn(),
}, config, ['value'], []);

expect(() => {
optionsManager.onOptionChanged({ name: 'value', value: 2, fullName: 'value' });
}).not.toThrow();
});

it('apply cfg-component option change if value really change', () => {
const TestContainer = (props: any) => {
const { value } = props;
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme-react/src/core/options-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class OptionsManager {
&& e.value instanceof Object
&& shallowEquals(value as Record<string, unknown>, e.value as Record<string, unknown>);

if (valuesAreEqual || valuesAreEqualObjects || this.instance.skipOptionsRollBack) {
if (valuesAreEqual || valuesAreEqualObjects || this.instance?.skipOptionsRollBack) {
return;
}

Expand Down
Loading