Skip to content

Accordion: allow validation messages to overflow in opened items (T1327641)#33512

Open
pharret31 wants to merge 2 commits intoDevExpress:26_1from
pharret31:26_1_4086-validation-message-truncation-in-accordion
Open

Accordion: allow validation messages to overflow in opened items (T1327641)#33512
pharret31 wants to merge 2 commits intoDevExpress:26_1from
pharret31:26_1_4086-validation-message-truncation-in-accordion

Conversation

@pharret31
Copy link
Copy Markdown
Contributor

No description provided.

@pharret31 pharret31 self-assigned this May 6, 2026
@pharret31 pharret31 added the 26_1 label May 6, 2026
Copilot AI review requested due to automatic review settings May 6, 2026 14:45
@pharret31 pharret31 requested a review from a team as a code owner May 6, 2026 14:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the DevExtreme Accordion’s runtime styling so validation messages (and other content) can visually overflow outside an opened item after the expand animation completes, and adds QUnit coverage to lock in the expected behavior.

Changes:

  • Reset inline overflow on items (and their bodies) when a height update/animation starts, so closing/opening transitions don’t keep overflow: visible.
  • Apply overflow: visible to opened items (and their bodies) once the open animation finishes.
  • Add QUnit tests covering opened/closed behavior, multiple mode, close-start reset, post-animation application, and reopen restoration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets/accordion.tests.js Adds a new test module validating overflow behavior across open/close scenarios and animation timing.
packages/devextreme/js/__internal/ui/accordion.ts Resets overflow at animation start and sets overflow: visible for opened items after animation completion.

Comment thread packages/devextreme/js/__internal/ui/accordion.ts
Comment thread packages/devextreme/js/__internal/ui/accordion.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants