List: screen reader should read selected state of items in multiselect mode (T1320659) #32360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds accessibility support for screen readers by introducing the aria-multiselectable="true" attribute to the List widget when it's in multi-select mode (selectionMode is 'multiple' or 'all'). This helps screen readers properly announce that multiple items can be selected in the list.
Changes:
- Added
_isMultiSelectMode()helper method to check if the List is in multiple/all selection mode - Updated
_setListAria()and_setGroupBodyAria()to conditionally set aria-multiselectable attribute - Added test coverage for both regular lists and collapsible groups with different selection modes
- Updated Jest snapshots to reflect the new aria attribute in header filter tests
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/list/list.base.ts | Added _isMultiSelectMode() method and integrated aria-multiselectable attribute into _setListAria() and _setGroupBodyAria() methods |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js | Added test fixture for expectedItemsContainerMultipleModeAttrs and updated tests to verify aria-multiselectable in multiselect mode |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/list.markup.tests.js | Added test fixture for expectedItemsContainerMultipleModeAttrs, updated existing tests, and added new tests for collapsible groups with multiselect/non-multiselect modes |
| packages/devextreme/testing/helpers/ariaAccessibilityTestHelper.js | Added getGroupContainers() helper method to support testing grouped lists |
| packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/snapshots/view.integration.test.tsx.snap | Updated snapshots to include aria-multiselectable="true" for header filter lists (which use multiselect mode) |
| packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/snapshots/options.integration.test.ts.snap | Updated snapshots to include aria-multiselectable="true" for header filter lists across various configurations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.