Skip to content

Conversation

@anna-shakhova
Copy link
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this Jan 29, 2026
@anna-shakhova anna-shakhova reopened this Jan 29, 2026
@anna-shakhova anna-shakhova reopened this Jan 29, 2026
@anna-shakhova anna-shakhova marked this pull request as ready for review January 29, 2026 14:58
@anna-shakhova anna-shakhova requested a review from a team as a code owner January 29, 2026 14:58
Copilot AI review requested due to automatic review settings January 29, 2026 14:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unskips two previously skipped DataGrid demo tests: RemoteGrouping and SignalRService. The PR updates test skip lists, improves the RemoteGrouping test implementation with better selectors and screenshot naming, modifies the SignalRService jQuery demo to wrap cell template content in wrapper divs, and changes the RemoteGrouping jQuery demo to use a different theme stylesheet.

Changes:

  • Removes 'RemoteGrouping' from skipped tests in visual test matrix across all frameworks (jQuery, Angular, React, Vue)
  • Removes 'SignalRService' from skipped tests configuration for Angular, React, and Vue
  • Updates RemoteGrouping test with improved selectors, adds initial screenshot, and renames screenshot files for clarity
  • Modifies SignalRService jQuery implementation to wrap cell template content in wrapper divs before appending to container
  • Changes RemoteGrouping jQuery demo from dx.light.css to dx.fluent.blue.light.css theme

Reviewed changes

Copilot reviewed 4 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/demos/utils/visual-tests/matrix-test-helper.ts Removes 'RemoteGrouping' from SKIPPED_TESTS for all frameworks (jQuery, Angular, React, Vue)
apps/demos/testing/skipped-tests.js Removes 'SignalRService' from skipped tests for Angular, React, and Vue frameworks
apps/demos/testing/widgets/datagrid/RemoteGrouping.test.ts Improves test with initial screenshot, better selector using .dx-datagrid-expand, and more descriptive screenshot filenames
apps/demos/Demos/DataGrid/SignalRService/jQuery/index.js Wraps cell template content in wrapper divs for both price and change columns to match intended DOM structure
apps/demos/Demos/DataGrid/RemoteGrouping/jQuery/index.html Changes theme stylesheet from dx.light.css to dx.fluent.blue.light.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants