Skip to content

fix(follow): track success with boolean flag instead of reply.statusCode #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anshul23102 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(follow): track success with boolean flag instead of reply.statusCode #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions apps/backend/src/routes/follow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { decrypt } from '../utils/encryption.js';
export async function followRoutes(app: FastifyInstance) {
app.addHook('preHandler', app.authenticate);

// ─── Follow via API (Layer 1) ───
// Follow via API (Layer 1)
// Currently supports: GitHub

app.post('/:platform/:targetUsername', async (
Expand Down Expand Up @@ -32,19 +32,20 @@ export async function followRoutes(app: FastifyInstance) {
const accessToken = decrypt(oauthToken.accessToken);

try {
let result;
let followSucceeded = false;

switch (platform) {
case 'github':
result = await followGitHub(accessToken, targetUsername, reply);
followSucceeded = await followGitHub(accessToken, targetUsername, reply);
break;
default:
return reply.status(400).send({
error: `API follow not supported for ${platform}. Use WebView or link instead.`,
});
}

// If follow succeeded (or was handled by the function without throwing), log it
if (reply.statusCode === 200 || reply.statusCode === 204) {
// Log only when the platform confirmed the follow succeeded
if (followSucceeded) {
app.prisma.followLog.create({
data: {
followerId: userId,
Expand All @@ -55,11 +56,9 @@ export async function followRoutes(app: FastifyInstance) {
},
}).catch(err => app.log.error('Failed to log follow:', err));
}

return result;
} catch (err: any) {
app.log.error(`Follow error for ${platform}:`, err);

app.prisma.followLog.create({
data: {
followerId: userId,
Expand All @@ -75,13 +74,14 @@ export async function followRoutes(app: FastifyInstance) {
});
}

// ─── GitHub Follow (Layer 1) ───
// GitHub Follow (Layer 1)
// Returns true when GitHub confirms the follow (204), false otherwise.

async function followGitHub(
accessToken: string,
targetUsername: string,
reply: FastifyReply
) {
): Promise<boolean> {
const response = await fetch(`https://api.github.com/user/following/${targetUsername}`, {
method: 'PUT',
headers: {
Expand All @@ -92,30 +92,34 @@ async function followGitHub(
});

if (response.status === 204) {
return reply.send({
reply.send({
status: 'success',
platform: 'github',
targetUsername,
message: `Now following ${targetUsername} on GitHub`,
});
return true;
}

if (response.status === 401 || response.status === 403) {
return reply.status(401).send({
reply.status(401).send({
error: 'GitHub token expired or insufficient permissions',
requiresAuth: true,
});
return false;
}

if (response.status === 404) {
return reply.status(404).send({
reply.status(404).send({
error: `GitHub user '${targetUsername}' not found`,
});
return false;
}

const errorBody = await response.text();
return reply.status(response.status).send({
reply.status(response.status).send({
error: 'GitHub follow failed',
details: errorBody,
});
return false;
}