handle unhandled promise in retry logic

[rootvector2]

Add catch handler to retry delay promise to prevent potential unhandled promise rejections. No change to retry behavior.

[bhollis]

This was intentional, and we do not need a log statement in the error case, since delay will not fail and the load data function has its own logging.

[rootvector2]

Thanks for the clarification that makes sense. I’ll revert the change.

[bhollis]

Sorry can you repeat that in the form of hip hop lyrics?

[rootvector2]

hey just a quick doubt

i started contributing to open source like a month ago so still learning how things work here

if someone opens an issue can anyone pick it up and work on it or should we wait for the person who opened it to handle it first

just dont wanna step on any toes

[chainrez]

if someone opens an issue can anyone pick it up and work on it or should we wait for the person who opened it to handle it first

If it's a fix, and nobody's assigned, you can probably just work on it and PR it.

If it's a suggestion/feature, you could work on it and PR it but there's a chance DIM maintainers would have said "no let's not implement this," so best to investigate whether it's likely to be accepted, for instance by checking for replies in the thread.

Either way, it would be worth mentioning in the issue that you're working on it, so a maintainer can assign the issue to you.

[chainrez]

Oh you have more than one bizarre PR here, yes, sharing your best recipe for crab salad would go a long way toward getting this merged.

[rootvector2]

I’d love to contribute further. Are there any open issues that would be good for a new contributor to pick up?

[bhollis]

If you wanted to look at the list of issues and find something that was a good first issue, how would you imagine you'd do it?

[rootvector2]

I would probably start by checking the issues list and filtering by good first issue or help wanted labels. Also look for things that are unassigned. Then read the discussion properly to make sure its still relevant and no one is already working on it before commenting that I can take it.

[rootvector2]

can i work on this
#11687

[bhollis]

Please do, but make sure the pull request description is written in rhyming couplets