Updated metric depth to point cloud code #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1ssb
commented
Jul 18, 2024
1ssb
commented
- Added auomatic downloaders
- Correct the depth2pointcloud code which was originally developed for batches
Contributor
Author
|
Hi @LiheYoung can you kindly merge this, there is an error in the last pushed code for certain CUDA versions. |
Contributor
|
Hi @1ssb, thank you for your contribution! Could I merge this PR for now? |
Contributor
Author
|
Hi Lilhe, Yes, and check out the additions to the Readme. Kindly note that in certain headless systems direct download of the checkpoints is not feasible. I have added the functionality to perform that as well.
Thanks!
Best
Subhransu
…________________________________
From: Lihe Yang ***@***.***>
Sent: Tuesday, August 13, 2024 5:36:18 PM
To: DepthAnything/Depth-Anything-V2 ***@***.***>
Cc: Subhransu Bhattacharjee ***@***.***>; Mention ***@***.***>
Subject: Re: [DepthAnything/Depth-Anything-V2] Updated metric depth to point cloud code (PR #89)
Hi @1ssb<https://github.com/1ssb>, thank you for your contribution! Could I merge this PR for now?
—
Reply to this email directly, view it on GitHub<#89 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJWHFEAG3FNCWDW5O6BVDYLZRHZDVAVCNFSM6AAAAABLBY6DHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBWGA4DOOJQHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
|
Thank you @1ssb! Maybe @bingykang could help merge this PR. |
|
That PR worked fantastically well to correct the depth to point cloud code. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.