Tag and mechanism to disable crafter slots #2781
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davight
reviewed
Oct 20, 2025
| } | ||
| for (String slot : input) { | ||
| ElementTag element = new ElementTag(slot); | ||
| if (element.isInt() && element.asInt() > 0 && element.asInt() <= 9) { |
Contributor
There was a problem hiding this comment.
i would probably put asInt() part into its own variable since its doing the same operation 3 times
tal5
requested changes
Nov 13, 2025
| // @mechanism LocationTag.crafter_disabled_slots | ||
| // @group world | ||
| // @description | ||
| // Returns the disabled slots of a crafter block from left to right, top to bottom. |
Member
There was a problem hiding this comment.
I'm not sure if the order of the list is something we should be guaranteeing here? Realistically any usage should depend on what the actual slots are, not where they are in the list.
| // Returns the disabled slots of a crafter block from left to right, top to bottom. | ||
| // --> | ||
| tagProcessor.registerTag(ListTag.class, "crafter_disabled_slots", (attribute, object) -> { | ||
| if (!(object.getBlockState() instanceof Crafter crafter)) { |
| // --> | ||
| tagProcessor.registerTag(ListTag.class, "crafter_disabled_slots", (attribute, object) -> { | ||
| if (!(object.getBlockState() instanceof Crafter crafter)) { | ||
| Debug.echoError("The 'LocationTag.crafter_disabled_slots' tag can only be called on a crafter block."); |
Comment on lines
4562
to
4564
| else { | ||
| mechanism.echoError("'" + slot + "' is not a valid slot for the 'crafter_disabled_slots' mechanism."); | ||
| } |
Member
There was a problem hiding this comment.
I'd early return this while you're at it
tal5
requested changes
Dec 12, 2025
| continue; | ||
| } | ||
| } | ||
| mechanism.echoError("'" + slot + "' is not a valid slot for the 'crafter_disabled_slots' mechanism."); |
Member
There was a problem hiding this comment.
This being here is a slightly confusing flow imo, as you have to look at the nested continue above and all - I'd just go with early returning on the int check &/ range check above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in a tag and mechanism to return and change the slots of a crafter block that are disabled.
Requested in https://discord.com/channels/315163488085475337/1417201910489939988
Open to naming suggestions, this was kind of the cleanest thing I could think of since there's already an EntityTag.disabled_slots