update invicti parser to use FirstSeenDate#14610
Open
paulOsinski wants to merge 6 commits intoDefectDojo:bugfixfrom
Open
update invicti parser to use FirstSeenDate#14610paulOsinski wants to merge 6 commits intoDefectDojo:bugfixfrom
paulOsinski wants to merge 6 commits intoDefectDojo:bugfixfrom
Conversation
Maffooch
requested changes
Apr 1, 2026
Contributor
Author
|
@Maffooch I have added the flag gating for |
Maffooch
approved these changes
Apr 11, 2026
valentijnscholten
approved these changes
Apr 11, 2026
Member
valentijnscholten
left a comment
There was a problem hiding this comment.
Looks good, but ideally we update the comment on the USE_FIRST_SEEN flag in settings.dist.py as it currently only mentions Qualys. Maybe also add a line to the docs for both parsers supporting this flag? Not blocking for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invicti parser will now apply FirstScanDate, if present, to the Finding's
dateobject. This change does not affect deduplication or anything destructive, we're simply parsing new data that we weren't before.